VaalaCat/go-openai
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Upgrade golangci-lint to 2.1.5 (#986)

Browse Source 
* Upgrade golangci-lint to 2.1.5

* update action
This commit is contained in:
Alex Baranov
2025-05-03 22:39:47 +01:00
committed by GitHub
parent 5ea214a188
commit 77ccac8d34
2 changed files with 167 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/pr.yml vendored
View File

@@ -18,9 +18,9 @@ jobs:
run: | run: |
go vet . go vet .
- name: Run golangci-lint - name: Run golangci-lint
uses: golangci/golangci-lint-action@v6 uses: golangci/golangci-lint-action@v7
with: with:
version: v1.64.5 version: v2.1.5
- name: Run tests - name: Run tests
run: go test -race -covermode=atomic -coverprofile=coverage.out -v ./... run: go test -race -covermode=atomic -coverprofile=coverage.out -v ./...
- name: Upload coverage reports to Codecov - name: Upload coverage reports to Codecov

420
.golangci.yml
View File

@@ -1,258 +1,168 @@
## Golden config for golangci-lint v1.47.3 version: "2"
#
# This is the best config for golangci-lint based on my experience and opinion.
# It is very strict, but not extremely strict.
# Feel free to adopt and change it for your needs.
run:
# Timeout for analysis, e.g. 30s, 5m.
# Default: 1m
timeout: 3m
# This file contains only configs which differ from defaults.
# All possible options can be found here https://github.com/golangci/golangci-lint/blob/master/.golangci.reference.yml
linters-settings:
cyclop:
# The maximal code complexity to report.
# Default: 10
max-complexity: 30
# The maximal average package complexity.
# If it's higher than 0.0 (float) the check is enabled
# Default: 0.0
package-average: 10.0
errcheck:
# Report about not checking of errors in type assertions: `a := b.(MyStruct)`.
# Such cases aren't reported by default.
# Default: false
check-type-assertions: true
funlen:
# Checks the number of lines in a function.
# If lower than 0, disable the check.
# Default: 60
lines: 100
# Checks the number of statements in a function.
# If lower than 0, disable the check.
# Default: 40
statements: 50
gocognit:
# Minimal code complexity to report
# Default: 30 (but we recommend 10-20)
min-complexity: 20
gocritic:
# Settings passed to gocritic.
# The settings key is the name of a supported gocritic checker.
# The list of supported checkers can be find in https://go-critic.github.io/overview.
settings:
captLocal:
# Whether to restrict checker to params only.
# Default: true
paramsOnly: false
underef:
# Whether to skip (*x).method() calls where x is a pointer receiver.
# Default: true
skipRecvDeref: false
mnd:
# List of function patterns to exclude from analysis.
# Values always ignored: `time.Date`
# Default: []
ignored-functions:
- os.Chmod
- os.Mkdir
- os.MkdirAll
- os.OpenFile
- os.WriteFile
- prometheus.ExponentialBuckets
- prometheus.ExponentialBucketsRange
- prometheus.LinearBuckets
- strconv.FormatFloat
- strconv.FormatInt
- strconv.FormatUint
- strconv.ParseFloat
- strconv.ParseInt
- strconv.ParseUint
gomodguard:
blocked:
# List of blocked modules.
# Default: []
modules:
- github.com/golang/protobuf:
recommendations:
- google.golang.org/protobuf
reason: "see https://developers.google.com/protocol-buffers/docs/reference/go/faq#modules"
- github.com/satori/go.uuid:
recommendations:
- github.com/google/uuid
reason: "satori's package is not maintained"
- github.com/gofrs/uuid:
recommendations:
- github.com/google/uuid
reason: "see recommendation from dev-infra team: https://confluence.gtforge.com/x/gQI6Aw"
govet:
# Enable all analyzers.
# Default: false
enable-all: true
# Disable analyzers by name.
# Run `go tool vet help` to see all analyzers.
# Default: []
disable:
- fieldalignment # too strict
# Settings per analyzer.
settings:
shadow:
# Whether to be strict about shadowing; can be noisy.
# Default: false
strict: true
nakedret:
# Make an issue if func has more lines of code than this setting, and it has naked returns.
# Default: 30
max-func-lines: 0
nolintlint:
# Exclude following linters from requiring an explanation.
# Default: []
allow-no-explanation: [ funlen, gocognit, lll ]
# Enable to require an explanation of nonzero length after each nolint directive.
# Default: false
require-explanation: true
# Enable to require nolint directives to mention the specific linter being suppressed.
# Default: false
require-specific: true
rowserrcheck:
# database/sql is always checked
# Default: []
packages:
- github.com/jmoiron/sqlx
tenv:
# The option `all` will run against whole test files (`_test.go`) regardless of method/function signatures.
# Otherwise, only methods that take `*testing.T`, `*testing.B`, and `testing.TB` as arguments are checked.
# Default: false
all: true
linters: linters:
disable-all: true default: none
enable: enable:
## enabled by default - asciicheck
- errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases - bidichk
- gosimple # Linter for Go source code that specializes in simplifying a code - bodyclose
- govet # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string - contextcheck
- ineffassign # Detects when assignments to existing variables are not used - cyclop
- staticcheck # Staticcheck is a go vet on steroids, applying a ton of static analysis checks - dupl
- unused # Checks Go code for unused constants, variables, functions and types - durationcheck
## disabled by default - errcheck
# - asasalint # Check for pass []any as any in variadic func(...any) - errname
- asciicheck # Simple linter to check that your code does not contain non-ASCII identifiers - errorlint
- bidichk # Checks for dangerous unicode character sequences - exhaustive
- bodyclose # checks whether HTTP response body is closed successfully - forbidigo
- contextcheck # check the function whether use a non-inherited context - funlen
- cyclop # checks function and package cyclomatic complexity - gochecknoinits
- dupl # Tool for code clone detection - gocognit
- durationcheck # check for two durations multiplied together - goconst
- errname # Checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error. - gocritic
- errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13. - gocyclo
- exhaustive # check exhaustiveness of enum switch statements - godot
- forbidigo # Forbids identifiers - gomoddirectives
- funlen # Tool for detection of long functions - gomodguard
# - gochecknoglobals # check that no global variables exist - goprintffuncname
- gochecknoinits # Checks that no init functions are present in Go code - gosec
- gocognit # Computes and checks the cognitive complexity of functions - govet
- goconst # Finds repeated strings that could be replaced by a constant - ineffassign
- gocritic # Provides diagnostics that check for bugs, performance and style issues. - lll
- gocyclo # Computes and checks the cyclomatic complexity of functions - makezero
- godot # Check if comments end in a period - mnd
- goimports # In addition to fixing imports, goimports also formats your code in the same style as gofmt. - nestif
- gomoddirectives # Manage the use of 'replace', 'retract', and 'excludes' directives in go.mod. - nilerr
- gomodguard # Allow and block list linter for direct Go module dependencies. This is different from depguard where there are different block types for example version constraints and module recommendations. - nilnil
- goprintffuncname # Checks that printf-like functions are named with f at the end - nolintlint
- gosec # Inspects source code for security problems - nosprintfhostport
- lll # Reports long lines - predeclared
- makezero # Finds slice declarations with non-zero initial length - promlinter
# - nakedret # Finds naked returns in functions greater than a specified function length - revive
- mnd # An analyzer to detect magic numbers. - rowserrcheck
- nestif # Reports deeply nested if statements - sqlclosecheck
- nilerr # Finds the code that returns nil even if it checks that the error is not nil. - staticcheck
- nilnil # Checks that there is no simultaneous return of nil error and an invalid value. - testpackage
# - noctx # noctx finds sending http request without context.Context - tparallel
- nolintlint # Reports ill-formed or insufficient nolint directives - unconvert
# - nonamedreturns # Reports all named returns - unparam
- nosprintfhostport # Checks for misuse of Sprintf to construct a host with port in a URL. - unused
- predeclared # find code that shadows one of Go's predeclared identifiers - usetesting
- promlinter # Check Prometheus metrics naming via promlint - wastedassign
- revive # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. - whitespace
- rowserrcheck # checks whether Err of rows is checked successfully settings:
- sqlclosecheck # Checks that sql.Rows and sql.Stmt are closed. cyclop:
- stylecheck # Stylecheck is a replacement for golint max-complexity: 30
- testpackage # linter that makes you use a separate _test package package-average: 10
- tparallel # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes errcheck:
- unconvert # Remove unnecessary type conversions check-type-assertions: true
- unparam # Reports unused function parameters funlen:
- usetesting # Reports uses of functions with replacement inside the testing package lines: 100
- wastedassign # wastedassign finds wasted assignment statements. statements: 50
- whitespace # Tool for detection of leading and trailing whitespace gocognit:
## you may want to enable min-complexity: 20
#- decorder # check declaration order and count of types, constants, variables and functions gocritic:
#- exhaustruct # Checks if all structure fields are initialized settings:
#- goheader # Checks is file header matches to pattern captLocal:
#- ireturn # Accept Interfaces, Return Concrete Types paramsOnly: false
#- prealloc # [premature optimization, but can be used in some cases] Finds slice declarations that could potentially be preallocated underef:
#- varnamelen # [great idea, but too many false positives] checks that the length of a variable's name matches its scope skipRecvDeref: false
#- wrapcheck # Checks that errors returned from external packages are wrapped gomodguard:
## disabled blocked:
#- containedctx # containedctx is a linter that detects struct contained context.Context field modules:
#- depguard # [replaced by gomodguard] Go linter that checks if package imports are in a list of acceptable packages - github.com/golang/protobuf:
#- dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) recommendations:
#- errchkjson # [don't see profit + I'm against of omitting errors like in the first example https://github.com/breml/errchkjson] Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occasions, where the check for the returned error can be omitted. - google.golang.org/protobuf
#- forcetypeassert # [replaced by errcheck] finds forced type assertions reason: see https://developers.google.com/protocol-buffers/docs/reference/go/faq#modules
#- gci # Gci controls golang package import order and makes it always deterministic. - github.com/satori/go.uuid:
#- godox # Tool for detection of FIXME, TODO and other comment keywords recommendations:
#- goerr113 # [too strict] Golang linter to check the errors handling expressions - github.com/google/uuid
#- gofmt # [replaced by goimports] Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification reason: satori's package is not maintained
#- gofumpt # [replaced by goimports, gofumports is not available yet] Gofumpt checks whether code was gofumpt-ed. - github.com/gofrs/uuid:
#- grouper # An analyzer to analyze expression groups. recommendations:
#- ifshort # Checks that your code uses short syntax for if-statements whenever possible - github.com/google/uuid
#- importas # Enforces consistent import aliases reason: 'see recommendation from dev-infra team: https://confluence.gtforge.com/x/gQI6Aw'
#- maintidx # maintidx measures the maintainability index of each function. govet:
#- misspell # [useless] Finds commonly misspelled English words in comments disable:
#- nlreturn # [too strict and mostly code is not more readable] nlreturn checks for a new line before return and branch statements to increase code clarity - fieldalignment
#- nosnakecase # Detects snake case of variable naming and function name. # TODO: maybe enable after https://github.com/sivchari/nosnakecase/issues/14 enable-all: true
#- paralleltest # [too many false positives] paralleltest detects missing usage of t.Parallel() method in your Go test settings:
#- tagliatelle # Checks the struct tags. shadow:
#- thelper # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers strict: true
#- wsl # [too strict and mostly code is not more readable] Whitespace Linter - Forces you to use empty lines! mnd:
ignored-functions:
- os.Chmod
issues: - os.Mkdir
# Maximum count of issues with the same text. - os.MkdirAll
# Set to 0 to disable. - os.OpenFile
# Default: 3 - os.WriteFile
max-same-issues: 50 - prometheus.ExponentialBuckets
- prometheus.ExponentialBucketsRange
exclude-rules: - prometheus.LinearBuckets
- source: "^//\\s*go:generate\\s" - strconv.FormatFloat
linters: [ lll ] - strconv.FormatInt
- source: "(noinspection|TODO)" - strconv.FormatUint
linters: [ godot ] - strconv.ParseFloat
- source: "//noinspection" - strconv.ParseInt
linters: [ gocritic ] - strconv.ParseUint
- source: "^\\s+if _, ok := err\\.\\([^.]+\\.InternalError\\); ok {" nakedret:
linters: [ errorlint ] max-func-lines: 0
- path: "_test\\.go" nolintlint:
linters: require-explanation: true
- bodyclose require-specific: true
- dupl allow-no-explanation:
- funlen - funlen
- goconst - gocognit
- gosec - lll
- noctx rowserrcheck:
- wrapcheck packages:
- github.com/jmoiron/sqlx
exclusions:
generated: lax
presets:
- comments
- common-false-positives
- legacy
- std-error-handling
rules:
- linters:
- forbidigo
- mnd
- revive
path : ^examples/.*\.go$
- linters:
- lll
source: ^//\s*go:generate\s
- linters:
- godot
source: (noinspection|TODO)
- linters:
- gocritic
source: //noinspection
- linters:
- errorlint
source: ^\s+if _, ok := err\.\([^.]+\.InternalError\); ok {
- linters:
- bodyclose
- dupl
- funlen
- goconst
- gosec
- noctx
- wrapcheck
- staticcheck
path: _test\.go
paths:
- third_party$
- builtin$
- examples$
issues:
max-same-issues: 50
formatters:
enable:
- goimports
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$