Fix Azure embeddings model detection by passing string to fullURL (#637)
This commit is contained in:
@@ -228,7 +228,7 @@ func (c *Client) CreateEmbeddings(
|
|||||||
conv EmbeddingRequestConverter,
|
conv EmbeddingRequestConverter,
|
||||||
) (res EmbeddingResponse, err error) {
|
) (res EmbeddingResponse, err error) {
|
||||||
baseReq := conv.Convert()
|
baseReq := conv.Convert()
|
||||||
req, err := c.newRequest(ctx, http.MethodPost, c.fullURL("/embeddings", baseReq.Model), withBody(baseReq))
|
req, err := c.newRequest(ctx, http.MethodPost, c.fullURL("/embeddings", string(baseReq.Model)), withBody(baseReq))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -158,6 +158,32 @@ func TestEmbeddingEndpoint(t *testing.T) {
|
|||||||
checks.HasError(t, err, "CreateEmbeddings error")
|
checks.HasError(t, err, "CreateEmbeddings error")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestAzureEmbeddingEndpoint(t *testing.T) {
|
||||||
|
client, server, teardown := setupAzureTestServer()
|
||||||
|
defer teardown()
|
||||||
|
|
||||||
|
sampleEmbeddings := []openai.Embedding{
|
||||||
|
{Embedding: []float32{1.23, 4.56, 7.89}},
|
||||||
|
{Embedding: []float32{-0.006968617, -0.0052718227, 0.011901081}},
|
||||||
|
}
|
||||||
|
|
||||||
|
server.RegisterHandler(
|
||||||
|
"/openai/deployments/text-embedding-ada-002/embeddings",
|
||||||
|
func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
resBytes, _ := json.Marshal(openai.EmbeddingResponse{Data: sampleEmbeddings})
|
||||||
|
fmt.Fprintln(w, string(resBytes))
|
||||||
|
},
|
||||||
|
)
|
||||||
|
// test create embeddings with strings (simple embedding request)
|
||||||
|
res, err := client.CreateEmbeddings(context.Background(), openai.EmbeddingRequest{
|
||||||
|
Model: openai.AdaEmbeddingV2,
|
||||||
|
})
|
||||||
|
checks.NoError(t, err, "CreateEmbeddings error")
|
||||||
|
if !reflect.DeepEqual(res.Data, sampleEmbeddings) {
|
||||||
|
t.Errorf("Expected %#v embeddings, got %#v", sampleEmbeddings, res.Data)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestEmbeddingResponseBase64_ToEmbeddingResponse(t *testing.T) {
|
func TestEmbeddingResponseBase64_ToEmbeddingResponse(t *testing.T) {
|
||||||
type fields struct {
|
type fields struct {
|
||||||
Object string
|
Object string
|
||||||
|
|||||||
Reference in New Issue
Block a user